[Doc][Fix] reveal the falsely hidden export command in the KubeRay GCS FT guide#53832
Merged
jjyao merged 1 commit intoray-project:masterfrom Jun 16, 2025
Merged
Conversation
…S FT guide Signed-off-by: Rueian <rueiancsie@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes a hidden cell containing the export YOUR_WORKER_POD=$(kubectl get pods -l ...) command visible in the KubeRay GCS fault-tolerance guide by removing the remove-cell tag.
- Unhide the export command cell so users can follow the guide end-to-end
Contributor
Author
|
cc @MortalHappiness and @kevin85421 for review. |
kevin85421
approved these changes
Jun 15, 2025
Member
kevin85421
left a comment
There was a problem hiding this comment.
@rueian Please ping me when all CI tests pass.
Member
|
@kevin85421 CI passed. |
Member
|
cc @jjyao would you mind merging this PR? Thanks! |
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
…S FT guide (#53832) Signed-off-by: Rueian <rueiancsie@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…S FT guide (ray-project#53832) Signed-off-by: Rueian <rueiancsie@gmail.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
…S FT guide (#53832) Signed-off-by: Rueian <rueiancsie@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
export YOUR_WORKER_POD=$(kubectl get pods -l ...)command should not be hidden; otherwise, users will not be able to follow the guide.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.