Skip to content

[serve] Revert request timeout from serve instance fixtures#53809

Merged
zcin merged 5 commits intoray-project:masterfrom
akyang-anyscale:alexyang/fix-test-backpressure
Jun 16, 2025
Merged

[serve] Revert request timeout from serve instance fixtures#53809
zcin merged 5 commits intoray-project:masterfrom
akyang-anyscale:alexyang/fix-test-backpressure

Conversation

@akyang-anyscale
Copy link
Copy Markdown
Contributor

@akyang-anyscale akyang-anyscale commented Jun 13, 2025

Why are these changes needed?

This PR removes the request timeout from the default serve test fixture since some tests have requests taking longer, and thus the tests are failing.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
@akyang-anyscale akyang-anyscale marked this pull request as draft June 13, 2025 17:30
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
@akyang-anyscale akyang-anyscale changed the title test [serve] Revert request timeout from serve instance fixtures Jun 14, 2025
@akyang-anyscale akyang-anyscale marked this pull request as ready for review June 14, 2025 00:21
@akyang-anyscale akyang-anyscale requested a review from a team as a code owner June 14, 2025 00:21
@akyang-anyscale akyang-anyscale added go add ONLY when ready to merge, run all tests labels Jun 14, 2025
@zcin zcin merged commit 74d9583 into ray-project:master Jun 16, 2025
6 checks passed
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
## Why are these changes needed?

This PR removes the request timeout from the default serve test fixture
since some tests have requests taking longer, and thus the tests are
failing.

---------

Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
…ect#53809)

## Why are these changes needed?

This PR removes the request timeout from the default serve test fixture
since some tests have requests taking longer, and thus the tests are
failing.

---------

Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
## Why are these changes needed?

This PR removes the request timeout from the default serve test fixture
since some tests have requests taking longer, and thus the tests are
failing.

---------

Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants