[tune] update BlockMetadata args in tests#53791
Merged
raulchen merged 1 commit intoray-project:masterfrom Jun 13, 2025
Merged
Conversation
Signed-off-by: Matthew Deng <matt@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test cases for BlockMetadata by removing the deprecated "schema" argument in two test files.
- Removed the "schema" parameter from the BlockMetadata instantiation in python/ray/tune/tests/test_tuner.py.
- Removed the "schema" parameter from the BlockMetadata instantiation in python/ray/tune/impl/test_utils.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/ray/tune/tests/test_tuner.py | Removed "schema" argument from BlockMetadata instantiation. |
| python/ray/tune/impl/test_utils.py | Removed "schema" argument from BlockMetadata instantiation. |
Comments suppressed due to low confidence (2)
python/ray/tune/tests/test_tuner.py:77
- The removal of the 'schema' parameter from the BlockMetadata instantiation is consistent with the updated API. Please confirm that any dependent tests or usage elsewhere have been updated accordingly.
schema=None,
python/ray/tune/impl/test_utils.py:22
- The 'schema' parameter removal here aligns with the new BlockMetadata API. Double-check that any assumptions regarding schema in tests are no longer required.
schema=None,
raulchen
approved these changes
Jun 13, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #53454
Closes #53786