Skip to content

[core] Increase instance sizes for wheel / HA tests#53783

Merged
jjyao merged 1 commit intoray-project:masterfrom
dayshah:increase-instance-sizes
Jun 13, 2025
Merged

[core] Increase instance sizes for wheel / HA tests#53783
jjyao merged 1 commit intoray-project:masterfrom
dayshah:increase-instance-sizes

Conversation

@dayshah
Copy link
Copy Markdown
Contributor

@dayshah dayshah commented Jun 12, 2025

Why are these changes needed?

Many of my pr's that change any gcs code fail on these because of bazel oom's on medium sized instances. It seems specific to ci steps that are building wheels or doing HA things.

Examples on 3 separate pr's:
https://buildkite.com/ray-project/premerge/builds/41945#_
https://buildkite.com/ray-project/premerge/builds/41876
https://buildkite.com/ray-project/premerge/builds/41774#01975b1b-3ca8-477a-a2a0-2efbc6099c4d

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <dhyey2019@gmail.com>
Copilot AI review requested due to automatic review settings June 12, 2025 23:07
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Jun 12, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the CI instance sizes from medium to large for wheel builds and HA integration tests to prevent Bazel OOM failures.

  • Bumped instance_type to large for Serve wheel and Python steps
  • Updated KubeRay operator test instance size
  • Increased core wheel and HA test instance sizes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.buildkite/serve.rayci.yml Changed instance_type to large for Serve steps
.buildkite/kuberay.rayci.yml Changed instance_type to large for operator test
.buildkite/core.rayci.yml Changed instance_type to large for core steps
Comments suppressed due to low confidence (1)

.buildkite/serve.rayci.yml:91

  • [nitpick] Several steps across YAML files repeat the same instance_type: large setting. Consider using a YAML anchor or default agent configuration to DRY up the pipeline and centralize instance size changes.
instance_type: large

Copy link
Copy Markdown
Contributor

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can be the cause? @aslonnie

@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jun 13, 2025

I have seen increased memory consumption when compiling locally lately as well.

@jjyao jjyao merged commit 7337f2a into ray-project:master Jun 13, 2025
3 of 4 checks passed
@dayshah dayshah deleted the increase-instance-sizes branch June 13, 2025 04:12
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants