[serve] Fix autoscaling metrics#53778
Merged
zcin merged 1 commit intoray-project:masterfrom Jun 13, 2025
Merged
Conversation
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the autoscaling metrics collection logic so that handle-level running request metrics are only aggregated when no metrics have been recorded on the replicas.
- Introduces a preliminary loop over replicas to sum running request metrics.
- Adds a conditional section in the handle metrics loop to conditionally aggregate running metrics.
Comments suppressed due to low confidence (1)
python/ray/serve/_private/autoscaling_state.py:302
- Avoid using 'id' as a variable name since it shadows the built-in function. Consider renaming it to 'replica_id' for clarity.
for id in self._running_replicas:
abrarsheikh
approved these changes
Jun 13, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
## Why are these changes needed? Only collect handle running request metrics if there are none recorded on the replicas. https://anyscale1.atlassian.net/browse/SERVE-848 Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
## Why are these changes needed? Only collect handle running request metrics if there are none recorded on the replicas. https://anyscale1.atlassian.net/browse/SERVE-848 Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Only collect handle running request metrics if there are none recorded on the replicas.
https://anyscale1.atlassian.net/browse/SERVE-848