[core] Deflake test_client_builder.py#53774
Merged
edoakes merged 4 commits intoray-project:masterfrom Jun 13, 2025
Merged
Conversation
edoakes
commented
Jun 12, 2025
Comment on lines
-108
to
-109
| @skip_flaky_core_test_premerge("https://github.com/ray-project/ray/issues/38224") | ||
| def test_connect_to_cluster(ray_start_regular_shared): |
Collaborator
Author
There was a problem hiding this comment.
the builder is deprecated, no sense spending time re-enabling this
edoakes
commented
Jun 12, 2025
d7168a8 to
0dd1ff4
Compare
jjyao
reviewed
Jun 13, 2025
| ray.client().connect() | ||
| assert len(ray._private.services.find_gcs_addresses()) == 1 | ||
| # Check that all three drivers started their own local clusters. | ||
| assert len({p1_node_id, p2_node_id, p3_node_id}) == 3 |
Contributor
There was a problem hiding this comment.
I know checking node id is better but do you know why ray._private.services.find_gcs_addresses() doesn't work?
Collaborator
Author
There was a problem hiding this comment.
Not sure, but _find_address_from_flag is super hacky. Maybe the proc commandline is slow to update or inconsistent?
jjyao
approved these changes
Jun 13, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Removes use of private API to check condition that local clusters were started. Instead, checks the node ID using a public API. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Removes use of private API to check condition that local clusters were started. Instead, checks the node ID using a public API. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes use of private API to check condition that local clusters were started. Instead, checks the node ID using a public API.