Skip to content

[data] Refactor interface for actor_pool_map_operator#53752

Merged
raulchen merged 2 commits intoray-project:masterfrom
omatthew98:mowen/refactor-actor-pool-map-op-interface
Jun 13, 2025
Merged

[data] Refactor interface for actor_pool_map_operator#53752
raulchen merged 2 commits intoray-project:masterfrom
omatthew98:mowen/refactor-actor-pool-map-op-interface

Conversation

@omatthew98
Copy link
Copy Markdown
Contributor

Why are these changes needed?

This PR cleans up the separation between the actor selection logic and the actor pool that the selectors are selected from.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@omatthew98 omatthew98 requested a review from a team as a code owner June 12, 2025 00:04
@omatthew98 omatthew98 added the go add ONLY when ready to merge, run all tests label Jun 12, 2025
@omatthew98 omatthew98 force-pushed the mowen/refactor-actor-pool-map-op-interface branch from 5c60cd2 to 383f0c1 Compare June 13, 2025 04:41
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
@omatthew98 omatthew98 force-pushed the mowen/refactor-actor-pool-map-op-interface branch from 383f0c1 to c894c58 Compare June 13, 2025 22:07
@raulchen raulchen merged commit 07f5096 into ray-project:master Jun 13, 2025
5 checks passed
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
## Why are these changes needed?
This PR cleans up the separation between the actor selection logic and
the actor pool that the selectors are selected from.

---------

Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
## Why are these changes needed?
This PR cleans up the separation between the actor selection logic and
the actor pool that the selectors are selected from.

---------

Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants