[core][telemetry] move the open telemetry tests into a pytest module#53751
Merged
can-anyscale merged 1 commit intomasterfrom Jun 12, 2025
Merged
[core][telemetry] move the open telemetry tests into a pytest module#53751can-anyscale merged 1 commit intomasterfrom
can-anyscale merged 1 commit intomasterfrom
Conversation
4f8f800 to
6c54242
Compare
Signed-off-by: can <can@anyscale.com>
6c54242 to
6cf0de0
Compare
can-anyscale
commented
Jun 12, 2025
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #ifdef _WIN32 |
Contributor
Author
There was a problem hiding this comment.
Fix this test while I'm here so the window builds pass - it's failing on postmerge with this error https://buildkite.com/ray-project/postmerge/builds/10800/steps/canvas?sid=0197628a-9327-4e25-98f0-2b8ddb361ec7#019762b8-4d70-4158-90d1-6ea6c9f17517/6-11641
dayshah
approved these changes
Jun 12, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
…53751) Move the open telemetry test from a buildkite job to a pytest module. This will allow the tests to also run in windows + macos environment. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This was referenced Jun 18, 2025
can-anyscale
pushed a commit
that referenced
this pull request
Jun 18, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
…53751) Move the open telemetry test from a buildkite job to a pytest module. This will allow the tests to also run in windows + macos environment. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the open telemetry test from a buildkite job to a pytest module. This will allow the tests to also run in windows + macos environment.
Test: