[serve] Improve test_metrics#53747
Merged
zcin merged 1 commit intoray-project:masterfrom Jun 12, 2025
Merged
Conversation
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve test debugging for metrics failures by enhancing the filtering and formatting of metric outputs.
- Importing the JSON module to format metric outputs
- Filtering metrics to only include those with the "ray_serve_" prefix
- Enhancing assertion error messages and debugging print statements with JSON formatting for clarity
| ), f"The following metrics don't sum to {expected}: {metric_samples}. {metrics}" | ||
| assert float(metric_sum) == float(expected), ( | ||
| f"The following metrics don't sum to {expected}: " | ||
| f"{json.dumps(metric_samples, indent=4)}\n." |
There was a problem hiding this comment.
[nitpick] Consider reviewing the punctuation in the error message; the '\n.' may be unintended and could be removed or clarified for better readability.
Suggested change
| f"{json.dumps(metric_samples, indent=4)}\n." | |
| f"{json.dumps(metric_samples, indent=4)}\n" |
akyang-anyscale
approved these changes
Jun 11, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
## Why are these changes needed? Make it easier to debug metrics test failures Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
## Why are these changes needed? Make it easier to debug metrics test failures Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make it easier to debug metrics test failures