ray-llm container cu124 -> cu128 update#53730
Merged
aslonnie merged 11 commits intoray-project:masterfrom Jun 13, 2025
Merged
Conversation
d029a97 to
bcfd177
Compare
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
a811c2f to
533c52c
Compare
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ray-llm container to support CUDA 12.8 (cu128) instead of CUDA 12.4 by revising the requirements files, Dockerfiles, and CI configuration files.
- Updated the autogenerated requirements files and associated command comments to reflect the new cu128 dependency indexes.
- Modified the Dockerfile and CI build configurations to use CUDA 12.8 images and parameters instead of cu124.
- Adjusted the compile_llm_requirements.sh script loop to iterate over the updated CUDA codes and removed the previous --find-links argument.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/requirements_* | Changed comments and command parameters from cu124 to cu128 for CUDA image consistency. |
| docker/ray-llm/Dockerfile | Updated the CUDA version comment and variable to cu128. |
| ci/* and .buildkite/* files | Adjusted CI build args and image references to use CUDA 12.8. |
| ci/compile_llm_requirements.sh | Updated CUDA codes in loop and removed the --find-links parameter for cu124. |
Comments suppressed due to low confidence (1)
ci/compile_llm_requirements.sh:25
- Please verify that removing the '--find-links' parameter for the updated CUDA configurations is intentional and that dependency resolution for cu128 will work correctly using only the extra-index-url.
--find-links "https://data.pyg.org/whl/torch-2.5.1+${CUDA_CODE}.html"
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
aslonnie
reviewed
Jun 13, 2025
Collaborator
aslonnie
left a comment
There was a problem hiding this comment.
ci is not passing. seems that some additional chnages are required.
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
aslonnie
approved these changes
Jun 13, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
upgrade to use cuda128 base images for both LLM CI test, release tests, and also for building ray-llm images. --------- Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
upgrade to use cuda128 base images for both LLM CI test, release tests, and also for building ray-llm images. --------- Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.