Conversation
Signed-off-by: abrar <abrar@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI failures by correcting the wrong import paths for test utilities. The changes update the import statements in several test files to use the correct module.
- Consolidated imports in test_output.py.
- Updated wait_for_condition imports in test_network_failure_e2e.py, test_dashboard.py, and test_job_agent.py.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/ray/tests/test_output.py | Combined wrong imports into a single correct import. |
| python/ray/tests/test_network_failure_e2e.py | Updated wait_for_condition import to the correct module. |
| python/ray/tests/test_dashboard.py | Updated wait_for_condition import to the correct module. |
| python/ray/dashboard/modules/job/tests/test_job_agent.py | Updated wait_for_condition import to the correct module. |
Contributor
Author
|
ran full CI https://buildkite.com/ray-project/postmerge/builds/10755 to be sure |
aslonnie
approved these changes
Jun 10, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
follow up of #53652 Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
follow up of #53652 Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up of #53652