[serve] Increase httpx timeout to 30s for backpressure test#53711
Merged
aslonnie merged 8 commits intoray-project:masterfrom Jun 11, 2025
Merged
[serve] Increase httpx timeout to 30s for backpressure test#53711aslonnie merged 8 commits intoray-project:masterfrom
aslonnie merged 8 commits intoray-project:masterfrom
Conversation
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
abrarsheikh
approved these changes
Jun 10, 2025
aslonnie
reviewed
Jun 10, 2025
| @ray.remote(num_cpus=0) | ||
| def do_request(msg: str) -> Tuple[int, str]: | ||
| r = httpx.request("GET", "http://localhost:8000/", json={"msg": msg}) | ||
| r = httpx.request("GET", "http://localhost:8000/", json={"msg": msg}, timeout=None) |
Collaborator
There was a problem hiding this comment.
maybe just make this long enough but not indefinitely?
Collaborator
There was a problem hiding this comment.
how long of timeout does it require for the test to pass?
Contributor
Author
There was a problem hiding this comment.
around 75s, will try 10 seconds, since we make ~12 of these http calls
Contributor
Author
There was a problem hiding this comment.
ok 10s failed, so setting to 30s, which works.
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Signed-off-by: akyang-anyscale <alexyang@anyscale.com>
Contributor
Author
|
@aslonnie could you help merge this? |
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
The test is failing on windows because of httpx client timeout. Previously with the `requests` library, there was no timeout set. Removing this timeout for httpx passes the test on windows. --------- Signed-off-by: akyang-anyscale <alexyang@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
The test is failing on windows because of httpx client timeout. Previously with the `requests` library, there was no timeout set. Removing this timeout for httpx passes the test on windows. --------- Signed-off-by: akyang-anyscale <alexyang@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is failing on windows because of httpx client timeout. Previously with the
requestslibrary, there was no timeout set. Removing this timeout for httpx passes the test on windows: https://buildkite.com/ray-project/microcheck/builds/18192/steps/canvas?sid=01975bcb-eac1-4804-a269-858ffdb32cf2.