[Serve][LLM] Simplify _prepare_engine_config()#53704
Merged
kouroshHakha merged 1 commit intoray-project:masterfrom Jun 17, 2025
Merged
[Serve][LLM] Simplify _prepare_engine_config()#53704kouroshHakha merged 1 commit intoray-project:masterfrom
kouroshHakha merged 1 commit intoray-project:masterfrom
Conversation
accelerator_type can be passed as None Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the GPU engine configuration flow by removing the conditional branch that checked accelerator_type and unifying on a single remote invocation with placement-group scheduling.
- Deleted the
if self.llm_config.accelerator_typebranch and its alternate GPU task setup. - Always uses the placement-group scheduling strategy for GPU-enabled tasks.
- Removed the manual
num_gpus=1fallback.
Comments suppressed due to low confidence (2)
python/ray/llm/_internal/serve/deployments/llm/vllm/vllm_engine.py:357
- The GPU remote invocation no longer specifies a GPU resource when
accelerator_typeis None, which could lead to tasks running without GPU access. Consider explicitly settingnum_gpus=1or verifying that the placement group always includes GPU resources.
ref = (
python/ray/llm/_internal/serve/deployments/llm/vllm/vllm_engine.py:356
- Add a unit test for the case where
llm_config.accelerator_typeis None to ensure GPU allocation still works under the new unified scheduling logic.
- if self.llm_config.accelerator_type:
lk-chen
approved these changes
Jun 16, 2025
Contributor
|
release tests: https://buildkite.com/ray-project/release/builds/45180 |
Contributor
|
@ruisearch42 remind me to merge if the release tests pass. |
Contributor
Author
|
@kouroshHakha release tests passed. |
kouroshHakha
approved these changes
Jun 17, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
accelerator_type can be passed as None
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.