[core] Fix test_multi_tenancy.py on Windows#53699
Merged
edoakes merged 1 commit intoray-project:masterfrom Jun 10, 2025
Merged
Conversation
israbbani
reviewed
Jun 10, 2025
Comment on lines
+257
to
+261
| try: | ||
| run_string_as_driver(driver_code) | ||
| except subprocess.CalledProcessError: | ||
| # The driver exits with non-zero status Windows due to ungraceful os._exit. | ||
| pass |
Contributor
There was a problem hiding this comment.
Did this test always fail and we just took it out of jail or is this non-deterministic?
Collaborator
Author
There was a problem hiding this comment.
I modified the test to add the os._exit (previously it wasn't doing this, so the driver was draining submitted tasks before exit, so it didn't actually test what it said it did)
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Process exits ungracefully when you `os._exit` on Windows: https://buildkite.com/ray-project/postmerge/builds/10736#01975889-d332-47e0-8290-284c63ec43b3/1834-1905 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Process exits ungracefully when you `os._exit` on Windows: https://buildkite.com/ray-project/postmerge/builds/10736#01975889-d332-47e0-8290-284c63ec43b3/1834-1905 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process exits ungracefully when you
os._exiton Windows: https://buildkite.com/ray-project/postmerge/builds/10736#01975889-d332-47e0-8290-284c63ec43b3/1834-1905