Skip to content

[core] Migrate ray.private.pydantic_compat from _private to _common#53686

Merged
edoakes merged 4 commits intoray-project:masterfrom
nehiljain:fix-53478-pydantic_compat
Jun 10, 2025
Merged

[core] Migrate ray.private.pydantic_compat from _private to _common#53686
edoakes merged 4 commits intoray-project:masterfrom
nehiljain:fix-53478-pydantic_compat

Conversation

@nehiljain
Copy link
Copy Markdown
Contributor

@nehiljain nehiljain commented Jun 10, 2025 •
edited
Loading

Why are these changes needed?

Related issue number

Fixes: #53478

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@nehiljain nehiljain requested review from a team, aslonnie and edoakes as code owners June 10, 2025 01:20
@nehiljain
Migrating pydantic compat utils from private to common
b79a541 
Signed-off-by: Nehil Jain <2761999+nehiljain@users.noreply.github.com>
@nehiljain nehiljain force-pushed the fix-53478-pydantic_compat branch from 2864a89 to b79a541 Compare June 10, 2025 01:22
@nehiljain nehiljain mentioned this pull request Jun 10, 2025
Open
@abrarsheikh abrarsheikh added the go add ONLY when ready to merge, run all tests label Jun 10, 2025
@nehiljain
Merge branch 'master' into fix-53478-pydantic_compat
aca6af7 
Signed-off-by: Nehil Jain <2761999+nehiljain@users.noreply.github.com>
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jun 10, 2025

Linter failure: https://buildkite.com/ray-project/premerge/builds/41759#01975a68-9240-401b-8409-b8cfdde6d6b3/185-270

There are instructions there on how to install & run pre-commit locally.

@nehiljain
Copy link
Copy Markdown
Contributor Author

nehiljain commented Jun 10, 2025

Linter failure: https://buildkite.com/ray-project/premerge/builds/41759#01975a68-9240-401b-8409-b8cfdde6d6b3/185-270

There are instructions there on how to install & run pre-commit locally.

Hehe, sorry I tried to be clever by resolving conflicts right in the github.com UI. Just fixed the linting issue.

@nehiljain
Fixing lint error
cb8ef1a 
Signed-off-by: Nehil Jain <2761999+nehiljain@users.noreply.github.com>
@nehiljain nehiljain force-pushed the fix-53478-pydantic_compat branch from ac478b2 to cb8ef1a Compare June 10, 2025 16:12
@edoakes edoakes merged commit 853e279 into ray-project:master Jun 10, 2025
5 checks passed
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jun 10, 2025

Thanks @nehiljain 💪

@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jun 10, 2025 •
edited
Loading

@nehiljain if you are hungry for more, you can consider converting all usage of ray._private.state to ray.util.state, such as:

tests/test_grpc.py:        _actors = ray._private.state.actors().values()
tests/test_grpc.py:    wait_for_condition(lambda: len(ray._private.state.actors()) == 5)
tests/test_grpc.py:        _actors = ray._private.state.actors().values()

@nehiljain
Copy link
Copy Markdown
Contributor Author

nehiljain commented Jun 10, 2025

@nehiljain if you are hungry for more, you can consider converting all usage of ray._private.state to ray.util.state, such as:

tests/test_grpc.py:        _actors = ray._private.state.actors().values()
tests/test_grpc.py:    wait_for_condition(lambda: len(ray._private.state.actors()) == 5)
tests/test_grpc.py:        _actors = ray._private.state.actors().values()

Will do this by EOW.

elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
@nehiljain @elliot-barn
[core] Migrate ray.private.pydantic_compat from _private to _common (#…
998470e 
…53686)

Fixes: #53478

---------

Signed-off-by: Nehil Jain <2761999+nehiljain@users.noreply.github.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
@nehiljain @elliot-barn
[core] Migrate ray.private.pydantic_compat from _private to _common (#…
0f3c325 
…53686)

Fixes: #53478

---------

Signed-off-by: Nehil Jain <2761999+nehiljain@users.noreply.github.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrarsheikh abrarsheikh abrarsheikh approved these changes

@aslonnie aslonnie aslonnie approved these changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[core|serve] Migrate shared utilities from ray._private to ray._common

4 participants

@nehiljain @edoakes @abrarsheikh @aslonnie