Skip to content

[refactor] Install uv from test-requirements.txt#53685

Closed
pcmoritz wants to merge 9 commits intoray-project:masterfrom
pcmoritz:uv-test-requirements
Closed

[refactor] Install uv from test-requirements.txt#53685
pcmoritz wants to merge 9 commits intoray-project:masterfrom
pcmoritz:uv-test-requirements

Conversation

@pcmoritz
Copy link
Copy Markdown
Contributor

@pcmoritz pcmoritz commented Jun 10, 2025 •
edited
Loading

Removes the manual download and installation of uv within the test_runtime_env_uv_run.py test file.

Instead, uv is now added as a dependency in
python/requirements/test-requirements.txt. The tests have been updated to use the uv executable directly, assuming it's installed in the environment.

This change simplifies the test setup and relies on the standard dependency management for uv. Updated uv to version 0.7.12.

Fixes #53650

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@google-labs-jules
Refactor: Install uv from test-requirements.txt
9093a79 
Removes the manual download and installation of `uv` within
the `test_runtime_env_uv_run.py` test file.

Instead, `uv` is now added as a dependency in
`python/requirements/test-requirements.txt`. The tests have been
updated to use the `uv` executable directly, assuming it's
installed in the environment.

This change simplifies the test setup and relies on the standard
dependency management for `uv`. Updated `uv` to version 0.7.12.
@pcmoritz pcmoritz added the go add ONLY when ready to merge, run all tests label Jun 10, 2025
@pcmoritz pcmoritz requested a review from jjyao June 10, 2025 04:25
jjyao
jjyao reviewed Jun 10, 2025
View reviewed changes
python/ray/tests/test_runtime_env_uv_run.py Outdated
def test_uv_run_pyproject(shutdown_only, with_uv, tmp_working_dir):
uv = with_uv
def test_uv_run_pyproject(shutdown_only, tmp_working_dir):
uv = "uv"
Copy link
Copy Markdown
Contributor

@jjyao jjyao Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_uv_bin()?

Copy link
Copy Markdown
Contributor Author

@pcmoritz pcmoritz Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed! :)

@jjyao
Copy link
Copy Markdown
Contributor

jjyao commented Jun 10, 2025

@pcmoritz some tests failed

@pcmoritz
Copy link
Copy Markdown
Contributor Author

pcmoritz commented Jun 10, 2025

@jjyao Thanks, I'm removing that test since I'm getting rid of that code path in #53690 anyways

@jjyao
Copy link
Copy Markdown
Contributor

jjyao commented Jun 10, 2025

@pcmoritz there are still some uv tests failed.

@pcmoritz pcmoritz mentioned this pull request Jun 11, 2025
Merged
8 tasks
pcmoritz added a commit that referenced this pull request Jun 11, 2025
@pcmoritz
Fix uv tests on macos x86_64 (#53741)
9e0eab2 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This fixes the architecture when downloading uv. Before we used i686
which is only available on linux (and even on linux it is actually not
the right architecture, x86_64 is better). Because i686 is not available
on mac os, it gave a 404 error when downloading uv.

Slightly more incremental than
#53685

Fixes #53650

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
@pcmoritz @elliot-barn
Fix uv tests on macos x86_64 (#53741)
ef771da 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This fixes the architecture when downloading uv. Before we used i686
which is only available on linux (and even on linux it is actually not
the right architecture, x86_64 is better). Because i686 is not available
on mac os, it gave a 404 error when downloading uv.

Slightly more incremental than
#53685

Fixes #53650

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 26, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 26, 2025
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
@pcmoritz @elliot-barn
Fix uv tests on macos x86_64 (#53741)
e079e97 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

This fixes the architecture when downloading uv. Before we used i686
which is only available on linux (and even on linux it is actually not
the right architecture, x86_64 is better). Because i686 is not available
on mac os, it gave a 404 error when downloading uv.

Slightly more incremental than
#53685

Fixes #53650

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 10, 2025

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Jul 10, 2025
aslonnie
aslonnie reviewed Aug 8, 2025
View reviewed changes
python/requirements_compiled.txt
Comment on lines +2449 to +2450
uv==0.7.12
# via -r python/requirements/test-requirements.txt
Copy link
Copy Markdown
Collaborator

@aslonnie aslonnie Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a different version from test-requirements.txt?

Copy link
Copy Markdown
Collaborator

@aslonnie aslonnie Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, this is a closed PR.

@jjyao jjyao mentioned this pull request Aug 11, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjyao jjyao jjyao left review comments

@aslonnie aslonnie aslonnie left review comments

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI test darwin://python/ray/tests:test_runtime_env_uv_run_client_mode is consistently_failing

3 participants

@pcmoritz @jjyao @aslonnie