Merged
Conversation
allowing people to check in byod scripts Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a misconfiguration in the CODEOWNERS file to allow people to check in BYOD post-installation shell scripts. The change narrows the file path to include only scripts in the designated BYOD directory.
- Updated the file path from a broad match (/release/ray_release/.sh) to a more specific one (/release/ray_release/byod/.sh).
Comments suppressed due to low confidence (1)
.github/CODEOWNERS:134
- Verify that narrowing the pattern to '/release/ray_release/byod/*.sh' doesn't unintentionally exclude any BYOD scripts that may be located outside this directory. If necessary, update documentation to clarify the new directory structure.
/release/ray_release/byod/*.sh
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
allowing people to check in byod scripts Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
allowing people to check in byod scripts Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allowing people to check in byod scripts