[core] Speed up & deflake test_multitenancy.py#53674
Merged
edoakes merged 2 commits intoray-project:masterfrom Jun 10, 2025
Merged
[core] Speed up & deflake test_multitenancy.py#53674edoakes merged 2 commits intoray-project:masterfrom
test_multitenancy.py#53674edoakes merged 2 commits intoray-project:masterfrom
Conversation
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Saw this flake on [postmerge](https://buildkite.com/ray-project/postmerge/builds/10702#01975572-3a26-4e0b-b27d-0869ac5830fe/177-1191). Cleaned up the test in general: - Remove sleep conditions. - Remove use of direct gRPC connection to raylet. - Remove runtime_env test that was redundant with `test_runtime_env_env_vars.py`. Runtime decreased by ~50% locally, from `62.98s` to `33.48s`. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Saw this flake on [postmerge](https://buildkite.com/ray-project/postmerge/builds/10702#01975572-3a26-4e0b-b27d-0869ac5830fe/177-1191). Cleaned up the test in general: - Remove sleep conditions. - Remove use of direct gRPC connection to raylet. - Remove runtime_env test that was redundant with `test_runtime_env_env_vars.py`. Runtime decreased by ~50% locally, from `62.98s` to `33.48s`. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw this flake on postmerge.
Cleaned up the test in general:
test_runtime_env_env_vars.py.Runtime decreased by ~50% locally, from
62.98sto33.48s.