Merged
Conversation
Signed-off-by: abrar <abrar@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors proxy error handling by extracting status mapping into helper functions and surfaces request timeout settings in tests.
- Adds
request_timeout_sto HTTP and gRPC options in tests for consistent timeout behavior. - Moves inline exception-to-status logic in
proxy.pyintoget_http_response_status,send_http_response_on_exception,get_grpc_response_status, andset_grpc_code_and_details.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/ray/serve/tests/test_controller.py | Added request_timeout_s to HTTP and gRPC options in tests. |
| python/ray/serve/tests/conftest.py | Added request_timeout_s to default serve start options. |
| python/ray/serve/_private/proxy.py | Replaced inline exception handlers with calls to new helpers. |
| python/ray/serve/_private/http_util.py | Introduced get_http_response_status and send_http_response_on_exception. |
| python/ray/serve/_private/grpc_util.py | Introduced get_grpc_response_status and set_grpc_code_and_details. |
Comments suppressed due to low confidence (1)
python/ray/serve/_private/http_util.py:656
- [nitpick] Add a docstring to
get_http_response_statusto explain its parameters and the mapping logic, improving clarity for future maintainers.
def get_http_response_status(
Collaborator
|
what's the context? |
Signed-off-by: abrar <abrar@anyscale.com>
akyang-anyscale
approved these changes
Jun 9, 2025
edoakes
approved these changes
Jun 9, 2025
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
LGTM, listen to the AI?
Signed-off-by: abrar <abrar@anyscale.com>
Collaborator
|
merge conflict |
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Signed-off-by: abrar <abrar@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.