[WIP] Only clear ObjectRef metadata for task arguments that have a non-default tensor transport#53630
Closed
stephanie-wang wants to merge 1 commit intoray-project:masterfrom
Closed
[WIP] Only clear ObjectRef metadata for task arguments that have a non-default tensor transport#53630stephanie-wang wants to merge 1 commit intoray-project:masterfrom
stephanie-wang wants to merge 1 commit intoray-project:masterfrom
Conversation
8 tasks
Member
|
Here is the PR based on this PR: #53692 |
stephanie-wang
added a commit
that referenced
this pull request
Jun 10, 2025
…t_ref` for small and non-GPU objects (#53692) This PR is based on #53630. See #53623 for the issue. In this PR, we clear the object ref when the arg's tensor transport is not OBJECT_STORE. Closes #53623 --------- Signed-off-by: Stephanie wang <smwang@cs.washington.edu> Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Stephanie wang <smwang@cs.washington.edu> Co-authored-by: Stephanie Wang <swang@cs.berkeley.edu>
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
…t_ref` for small and non-GPU objects (#53692) This PR is based on #53630. See #53623 for the issue. In this PR, we clear the object ref when the arg's tensor transport is not OBJECT_STORE. Closes #53623 --------- Signed-off-by: Stephanie wang <smwang@cs.washington.edu> Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Stephanie wang <smwang@cs.washington.edu> Co-authored-by: Stephanie Wang <swang@cs.berkeley.edu> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
…t_ref` for small and non-GPU objects (#53692) This PR is based on #53630. See #53623 for the issue. In this PR, we clear the object ref when the arg's tensor transport is not OBJECT_STORE. Closes #53623 --------- Signed-off-by: Stephanie wang <smwang@cs.washington.edu> Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Stephanie wang <smwang@cs.washington.edu> Co-authored-by: Stephanie Wang <swang@cs.berkeley.edu> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When an object with a non-default tensor transport is passed as an argument to another task, the task needs to know the object ID so that it can fetch the remaining data through the out-of-band tensor transport. Previously, this metadata would get cleared for inlined objects, but we need to retain it for these partially inlined objects. This PR adds a tensor transport field for ObjectRefs in C++ so that that the dependency resolver can check whether it should retain the ObjectRef metadata or not for downstream tasks.
Related issue number
Closes #53623.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.