Replace python setup.py bdist_wheel with pip wheel#53458
Merged
aslonnie merged 6 commits intoray-project:masterfrom Jun 14, 2025
Merged
Replace python setup.py bdist_wheel with pip wheel#53458aslonnie merged 6 commits intoray-project:masterfrom
python setup.py bdist_wheel with pip wheel#53458aslonnie merged 6 commits intoray-project:masterfrom
Conversation
Collaborator
this will now build/download a lot of extra files inside the output directory. can we fix this so that it still only outputs ray/ray-cpp wheels? |
aslonnie
reviewed
Jun 2, 2025
Collaborator
aslonnie
left a comment
There was a problem hiding this comment.
it works, but this now will build/download a lot of extra files inside the output directory.
can we fix this so that it still only outputs ray/ray-cpp wheels?
Collaborator
|
seems that it is moving a temp directory. |
Contributor
Author
|
I think, it will require passing Edit - It seems to work, (ray-dev) PS C:\Users\czgdp1807\Anyscale\ray\python\dist> ls
Directory: C:\Users\czgdp1807\Anyscale\ray\python\dist
Mode LastWriteTime Length Name
---- ------------- ------ ----
-a---- 6/7/2025 4:25 PM 24460102 ray-3.0.0.dev0-cp39-cp39-win_amd64.whl
|
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com>
aslonnie
approved these changes
Jun 14, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
This PR replaces python setup.py bdist_wheel invocations with pip wheel because calling python setup.py bdist_wheel is deprecated. See https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ for more information and https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for a discussion about why this needs to be changed. --------- Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
This PR replaces python setup.py bdist_wheel invocations with pip wheel because calling python setup.py bdist_wheel is deprecated. See https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ for more information and https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for a discussion about why this needs to be changed. --------- Signed-off-by: Gagandeep Singh <gdp.1807@gmail.com> Co-authored-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR replaces
python setup.py bdist_wheelinvocations with pip wheel because callingpython setup.py bdist_wheelis deprecated. See https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ for more information and https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for a discussion about why this needs to be changed.cc: @peytondmurray
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.