Skip to content

[core] early exit spill if spilling config is empty#53193

Merged
edoakes merged 5 commits intoray-project:masterfrom
tianyi-ge:early-exit-spill-if-empty-config
Jun 10, 2025
Merged

[core] early exit spill if spilling config is empty#53193
edoakes merged 5 commits intoray-project:masterfrom
tianyi-ge:early-exit-spill-if-empty-config

Conversation

@tianyi-ge
Copy link
Copy Markdown
Contributor

@tianyi-ge tianyi-ge commented May 21, 2025 •
edited
Loading

Why are these changes needed?

Even though there's no spilling happening, ray still logs "trying to spill." Add an early exit to avoid confusing logs.

Related issue number

Closes #53086

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@tianyi-ge
Copy link
Copy Markdown
Contributor Author

tianyi-ge commented May 21, 2025

Hi @israbbani can you take a look?

@israbbani israbbani self-assigned this Jun 9, 2025
@mascharkh mascharkh added community-contribution Contributed by the community core Issues that should be addressed in Ray Core labels Jun 10, 2025
israbbani
israbbani approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@israbbani israbbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Thanks for the contribution!

@jjyao / @edoakes can you merge please?

edoakes
edoakes approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jun 10, 2025
@edoakes edoakes enabled auto-merge (squash) June 10, 2025 15:18
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jun 10, 2025

I added go label to run CI tests and enabled auto-merge. If they don't pass, please update branch to master and then ping me to merge.

@edoakes edoakes merged commit 8e30ee1 into ray-project:master Jun 10, 2025
7 checks passed
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
@tianyi-ge @elliot-barn
[core] early exit spill if spilling config is empty (#53193)
09ac94d 
Even though there's no spilling happening, ray still logs "trying to
spill." Add an early exit to avoid confusing logs.

Closes #53086

Signed-off-by: tianyi-ge <tianyig@outlook.com>
Co-authored-by: Ibrahim Rabbani <irabbani@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
@tianyi-ge @elliot-barn
[core] early exit spill if spilling config is empty (#53193)
6140050 
Even though there's no spilling happening, ray still logs "trying to
spill." Add an early exit to avoid confusing logs.

Closes #53086

Signed-off-by: tianyi-ge <tianyig@outlook.com>
Co-authored-by: Ibrahim Rabbani <irabbani@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@israbbani israbbani israbbani approved these changes

@edoakes edoakes edoakes approved these changes

Assignees

@israbbani israbbani

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Core] Ray doesn't respect object_store_memory when spilling is disabled

5 participants

@tianyi-ge @edoakes @israbbani @mascharkh @hainesmichaelc