Skip to content

[core][refactor] Remove OnClientConnected#52249

Merged
jjyao merged 1 commit intomasterfrom
laptop-ray3-20250410
Apr 11, 2025
Merged

[core][refactor] Remove OnClientConnected#52249
jjyao merged 1 commit intomasterfrom
laptop-ray3-20250410

Conversation

@kevin85421
Copy link
Copy Markdown
Member

@kevin85421 kevin85421 commented Apr 11, 2025 •
edited
Loading

Why are these changes needed?

All OnClientConnected implementations are empty after #51904.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421
up
495c66e 
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421 kevin85421 mentioned this pull request Apr 11, 2025
Merged
8 tasks
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Apr 11, 2025
@jjyao jjyao marked this pull request as ready for review April 11, 2025 14:28
@jjyao jjyao merged commit 251e301 into master Apr 11, 2025
5 checks passed
@jjyao jjyao deleted the laptop-ray3-20250410 branch April 11, 2025 14:28
han-steve pushed a commit to han-steve/ray that referenced this pull request Apr 11, 2025
@kevin85421 @han-steve
[core][refactor] Remove OnClientConnected (ray-project#52249)
dfd3184 
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Steve Han <stevehan2001@gmail.com>
@kevin85421 kevin85421 mentioned this pull request May 3, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjyao jjyao jjyao approved these changes

Assignees

No one assigned

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevin85421 @jjyao @hainesmichaelc