Skip to content

[core][refactor] Make tasks_to_resubmit more deterministic#52225

Merged
jjyao merged 4 commits intoray-project:masterfrom
kevin85421:laptop-ray2-20250410
Apr 11, 2025
Merged

[core][refactor] Make tasks_to_resubmit more deterministic#52225
jjyao merged 4 commits intoray-project:masterfrom
kevin85421:laptop-ray2-20250410

Conversation

@kevin85421
Copy link
Copy Markdown
Member

@kevin85421 kevin85421 commented Apr 10, 2025 •
edited
Loading

Why are these changes needed?

Currently, each iteration of the loop that selects tasks_to_resubmit uses different values for comparison with execution_time_ms. Consequently, some tasks with smaller execution_time_ms values might not be selected for resubmission during this call of InternalHeartbeat.

Follow up of #51904 (comment)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421
up
1471997 
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421
up
5969d65 
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Apr 10, 2025
@kevin85421
up
f7fd097 
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
@kevin85421 kevin85421 mentioned this pull request Apr 10, 2025
Merged
8 tasks
@kevin85421 kevin85421 marked this pull request as ready for review April 10, 2025 23:40
jjyao
jjyao reviewed Apr 11, 2025
View reviewed changes
@kevin85421 @jjyao
Update src/ray/core_worker/core_worker.cc
6bd7e39 
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
@jjyao jjyao merged commit 055f6f9 into ray-project:master Apr 11, 2025
5 checks passed
han-steve pushed a commit to han-steve/ray that referenced this pull request Apr 11, 2025
@kevin85421 @han-steve
[core][refactor] Make tasks_to_resubmit more deterministic (ray-pro…
36ab90f 
…ject#52225)

Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
Signed-off-by: Steve Han <stevehan2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjyao jjyao jjyao approved these changes

Assignees

@jjyao jjyao

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevin85421 @jjyao @hainesmichaelc