Skip to content

[KubeRay][Docs] Update troubleshooting.md to reference working version of Ray#52176

Merged
jjyao merged 2 commits intoray-project:masterfrom
samhallam-reverb:patch-1
Apr 9, 2025
Merged

[KubeRay][Docs] Update troubleshooting.md to reference working version of Ray#52176
jjyao merged 2 commits intoray-project:masterfrom
samhallam-reverb:patch-1

Conversation

@samhallam-reverb
Copy link
Copy Markdown
Contributor

@samhallam-reverb samhallam-reverb commented Apr 9, 2025

Why are these changes needed?

This example suggests using a version of Ray that has a bug per the previous section. This updates the example to reference a compatible image.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

This example suggests using a version of Ray that has a bug per the previous section. This updates the example to reference a compatible image.

Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
@samhallam-reverb samhallam-reverb requested review from a team, kevin85421 and pcmoritz as code owners April 9, 2025 15:04
@samhallam-reverb samhallam-reverb changed the title Update troubleshooting.md Update troubleshooting.md to reference working version of Ray Apr 9, 2025
@samhallam-reverb samhallam-reverb changed the title Update troubleshooting.md to reference working version of Ray [KubeRay][Docs] Update troubleshooting.md to reference working version of Ray Apr 9, 2025
Copy link
Copy Markdown
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using 2.41 instead to be consistent with the sample YAMLs for KubeRay v1.3.0?

@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label Apr 9, 2025
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Apr 9, 2025
@kevin85421
Copy link
Copy Markdown
Member

@samhallam-reverb, I have triggered the full CI tests. Please ping me when the CI passes. Thanks!

@samhallam-reverb
Copy link
Copy Markdown
Contributor Author

@kevin85421 Looks like we're all good!

@kevin85421
Copy link
Copy Markdown
Member

cc @jjyao @edoakes for merge.

@jjyao jjyao merged commit 469c396 into ray-project:master Apr 9, 2025
6 checks passed
han-steve pushed a commit to han-steve/ray that referenced this pull request Apr 11, 2025
…n of Ray (ray-project#52176)

Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Steve Han <stevehan2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog community-contribution Contributed by the community go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants