Skip to content

[core] Skip sigkill actor failure tests on windows#52135

Merged
jjyao merged 1 commit intoray-project:masterfrom
dayshah:skip-actor-failure-win
Apr 9, 2025
Merged

[core] Skip sigkill actor failure tests on windows#52135
jjyao merged 1 commit intoray-project:masterfrom
dayshah:skip-actor-failure-win

Conversation

@dayshah
Copy link
Copy Markdown
Contributor

@dayshah dayshah commented Apr 9, 2025

Why are these changes needed?

These tests fail on windows because sigkill doesn't exist on windows.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah requested review from jjyao and kevin85421 April 9, 2025 05:42
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Apr 9, 2025
@jjyao jjyao enabled auto-merge (squash) April 9, 2025 06:32
@dayshah
Copy link
Copy Markdown
Contributor Author

dayshah commented Apr 9, 2025

unrelated test failures @jjyao

@jjyao jjyao disabled auto-merge April 9, 2025 14:05
@jjyao jjyao merged commit 09fdba8 into ray-project:master Apr 9, 2025
4 of 6 checks passed
han-steve pushed a commit to han-steve/ray that referenced this pull request Apr 11, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: Steve Han <stevehan2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants