[core] Skip sigkill actor failure tests on windows#52135
Merged
jjyao merged 1 commit intoray-project:masterfrom Apr 9, 2025
Merged
[core] Skip sigkill actor failure tests on windows#52135jjyao merged 1 commit intoray-project:masterfrom
jjyao merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: dayshah <dhyey2019@gmail.com>
jjyao
approved these changes
Apr 9, 2025
Contributor
Author
|
unrelated test failures @jjyao |
han-steve
pushed a commit
to han-steve/ray
that referenced
this pull request
Apr 11, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Steve Han <stevehan2001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These tests fail on windows because sigkill doesn't exist on windows.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.