Skip to content

[Core] Disable dashboard log rotation for windows#52134

Merged
jjyao merged 3 commits intoray-project:masterfrom
jjyao:jjyao/wwin
Apr 9, 2025
Merged

[Core] Disable dashboard log rotation for windows#52134
jjyao merged 3 commits intoray-project:masterfrom
jjyao:jjyao/wwin

Conversation

@jjyao
Copy link
Copy Markdown
Contributor

@jjyao jjyao commented Apr 9, 2025

Why are these changes needed?

Dashboard subprocess should use the logging rotation configs from the parent that is properly disabled for windows.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Apr 9, 2025
@jjyao jjyao marked this pull request as ready for review April 9, 2025 06:31
@jjyao
Copy link
Copy Markdown
Contributor Author

jjyao commented Apr 9, 2025

Failed tests are unrelated.

@jjyao jjyao merged commit b43fe2b into ray-project:master Apr 9, 2025
4 of 5 checks passed
@jjyao jjyao deleted the jjyao/wwin branch April 9, 2025 14:21
han-steve pushed a commit to han-steve/ray that referenced this pull request Apr 11, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Steve Han <stevehan2001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants