[core] Use a signal actor instead of sleep to avoid flakiness in extreme cases#52121
Merged
[core] Use a signal actor instead of sleep to avoid flakiness in extreme cases#52121
Conversation
8 tasks
Member
Author
|
CI failures seem to be unrelated. |
jjyao
reviewed
Apr 9, 2025
Comment on lines
+1177
to
+1178
| ray.get(signal_actor.send.remote(clear=True)) | ||
| ray.get(signal_actor.wait.remote()) |
Contributor
There was a problem hiding this comment.
I think we need to use two different signal actors otherwise if signal_actor.send.remote(clear=True) happens before ray.get(signal_actor.wait.remote()), the signal is lost.
Member
Author
There was a problem hiding this comment.
I removed clear=True from the last send in these two tests instead.
Member
Author
There was a problem hiding this comment.
I eventually decided to use two signal actors because I found that I still needed two actors even if I use semaphores.
Member
Author
|
CI failures seem to be unrelated. |
jjyao
approved these changes
Apr 10, 2025
han-steve
pushed a commit
to han-steve/ray
that referenced
this pull request
Apr 11, 2025
…eme cases (ray-project#52121) Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Signed-off-by: Steve Han <stevehan2001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Follow up of #51904 (comment).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.