[Data] Replace BlockAccessor.append_column with BlockAccessor.fill_column#52112
Merged
bveeramani merged 6 commits intomasterfrom Apr 9, 2025
Merged
[Data] Replace BlockAccessor.append_column with BlockAccessor.fill_column#52112bveeramani merged 6 commits intomasterfrom
BlockAccessor.append_column with BlockAccessor.fill_column#52112bveeramani merged 6 commits intomasterfrom
Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
|
|
||
| return self._table.append_column(name, [data]) | ||
| array = pa.nulls(len(self._table), type=type) | ||
| array = pc.fill_null(array, value) |
Contributor
There was a problem hiding this comment.
Value have to be converted to Pyarrow Scalar
Member
Author
There was a problem hiding this comment.
What's the advantage of explicitly converting value to a scalar rather than letting PyArrow internally handle the conversion?
Contributor
There was a problem hiding this comment.
Does it work w/o converting to scalar?
Member
Author
There was a problem hiding this comment.
Yeah. We test both cases in test_arrow_block::test_fill_column
alexeykudinkin
approved these changes
Apr 9, 2025
| f"`{self.__class__.__name__}.append_column()` doesn't support " | ||
| "array-like data." | ||
| ) | ||
| import pyarrow as pa |
Contributor
There was a problem hiding this comment.
There's a top-level pyarrow import already, no need for local one
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
han-steve
pushed a commit
to han-steve/ray
that referenced
this pull request
Apr 11, 2025
…_column` (ray-project#52112) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> If you're using PyArrow 12 or earlier and pass in a list of scalars to `BlockAccessor.append_column`, the method raises an error. To address this issue, this PR re-implements the method. ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Steve Han <stevehan2001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If you're using PyArrow 12 or earlier and pass in a list of scalars to
BlockAccessor.append_column, the method raises an error. To address this issue, this PR re-implements the method.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.