[RLlib] Remove local EnvRunner (optional).#52091
Merged
sven1977 merged 25 commits intoray-project:masterfrom Apr 11, 2025
Merged
[RLlib] Remove local EnvRunner (optional).#52091sven1977 merged 25 commits intoray-project:masterfrom
sven1977 merged 25 commits intoray-project:masterfrom
Conversation
…ve_local_env_runner
simonsays1980
approved these changes
Apr 9, 2025
Contributor
simonsays1980
left a comment
There was a problem hiding this comment.
LGTM. Great work @sven1977! The only dumb question I have is: do we then - for new stack - even still need the case with create_local_env_runner=True?
rllib/algorithms/algorithm.py
Outdated
| if self.env_runner_group: | ||
| self.env_runner.set_state(rl_module_state) | ||
| # if self.env_runner is not None: | ||
| # self.env_runner.set_state(rl_module_state) |
| # new states back to all EnvRunners. | ||
| with self.metrics.log_time((TIMERS, SYNCH_ENV_CONNECTOR_STATES_TIMER)): | ||
| self.env_runner_group.sync_env_runner_states(config=self.config) | ||
| self.env_runner_group.sync_env_runner_states( |
Contributor
There was a problem hiding this comment.
Don't we need a merge anywhere?
| because it doesn't have to sample (done by remote_workers; | ||
| worker_indices > 0) nor evaluate (done by evaluation workers; | ||
| see below). | ||
| create_local_env_runner: If True, create a local EnvRunner instance, besides |
Contributor
There was a problem hiding this comment.
Dumb question: Do we need the local EnvRunner anyways then anymore?
Contributor
Author
There was a problem hiding this comment.
Trying to get rid of it for good. But for now leaving this still as optional ...
…ve_local_env_runner
auto-merge was automatically disabled
April 9, 2025 14:00
Pull Request is not mergeable
…ve_local_env_runner
…ve_local_env_runner
han-steve
pushed a commit
to han-steve/ray
that referenced
this pull request
Apr 11, 2025
Signed-off-by: Steve Han <stevehan2001@gmail.com>
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove local EnvRunner (optional).
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.