Remove ray.data code from global doctest conftest#51334
Merged
edoakes merged 17 commits intoray-project:masterfrom Mar 19, 2025
Merged
Remove ray.data code from global doctest conftest#51334edoakes merged 17 commits intoray-project:masterfrom
ray.data code from global doctest conftest#51334edoakes merged 17 commits intoray-project:masterfrom
Conversation
Collaborator
Author
|
@bveeramani PTAL |
8 tasks
8 tasks
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Collaborator
Author
|
There is a problem with the current approach because the hard-coded Trying to figure out how to pass it as a "module" using |
…es/rm-data-from-conftest
aslonnie
reviewed
Mar 18, 2025
Collaborator
aslonnie
left a comment
There was a problem hiding this comment.
is this ready for review?
Collaborator
Author
Not yet; please hold |
Collaborator
Author
|
@aslonnie ready now! |
edoakes
commented
Mar 18, 2025
Comment on lines
+429
to
+430
| "source/data/**/*.rst", | ||
| "source/data/**/*.md", |
Collaborator
Author
There was a problem hiding this comment.
moved to data target below
Collaborator
Author
|
@bveeramani ping |
bveeramani
approved these changes
Mar 18, 2025
Member
bveeramani
left a comment
There was a problem hiding this comment.
Nice, looks reasonable to me.
LGTM assuming CI runs all of the Data doctests and passes.
Collaborator
Author
|
Looks like there might be some docstrings that weren't being tested before and are being tested now... will dig |
aslonnie
approved these changes
Mar 18, 2025
…es/rm-data-from-conftest
dhakshin32
pushed a commit
to dhakshin32/ray
that referenced
this pull request
Mar 27, 2025
Moves data-specific functionality out of the global default fixtures that are installed for `doctest` builds. The way this was currently implemented basically hard-coded the global `conftest.py` file. I had to rework this to be installed as a pytest "plugin" using the `-p` argument instead. The `doctest` build now allows overriding the plugin file. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
8 tasks
bveeramani
added a commit
that referenced
this pull request
Aug 20, 2025
In #51334, we discovered we weren't actually testing code snippets in our user guides. As a result, there are several broken code snippets in our guides. This PR fixes some of those code snippets, and re-enables testing on the user guides. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
ljstrnadiii
pushed a commit
to ljstrnadiii/ray
that referenced
this pull request
Aug 21, 2025
In ray-project#51334, we discovered we weren't actually testing code snippets in our user guides. As a result, there are several broken code snippets in our guides. This PR fixes some of those code snippets, and re-enables testing on the user guides. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
ljstrnadiii
pushed a commit
to ljstrnadiii/ray
that referenced
this pull request
Aug 21, 2025
In ray-project#51334, we discovered we weren't actually testing code snippets in our user guides. As a result, there are several broken code snippets in our guides. This PR fixes some of those code snippets, and re-enables testing on the user guides. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: ljstrnadiii <ljstrnadiii@gmail.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
In ray-project#51334, we discovered we weren't actually testing code snippets in our user guides. As a result, there are several broken code snippets in our guides. This PR fixes some of those code snippets, and re-enables testing on the user guides. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
In ray-project#51334, we discovered we weren't actually testing code snippets in our user guides. As a result, there are several broken code snippets in our guides. This PR fixes some of those code snippets, and re-enables testing on the user guides. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
In ray-project#51334, we discovered we weren't actually testing code snippets in our user guides. As a result, there are several broken code snippets in our guides. This PR fixes some of those code snippets, and re-enables testing on the user guides. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Moves data-specific functionality out of the global default fixtures that are installed for
doctestbuilds.The way this was currently implemented basically hard-coded the global
conftest.pyfile. I had to rework this to be installed as a pytest "plugin" using the-pargument instead. Thedoctestbuild now allows overriding the plugin file.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.