[Core] Report cluster config from autoscaler#49568
Merged
jjyao merged 11 commits intoray-project:masterfrom Jan 8, 2025
Merged
[Core] Report cluster config from autoscaler#49568jjyao merged 11 commits intoray-project:masterfrom
jjyao merged 11 commits intoray-project:masterfrom
Conversation
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
raulchen
approved these changes
Jan 4, 2025
src/ray/protobuf/autoscaler.proto
Outdated
| } | ||
|
|
||
| message NodeGroupConfig { | ||
| map<string, double> resources = 1; |
Contributor
There was a problem hiding this comment.
https://github.com/anyscale/product/blob/d27096d7b38faf091b3dd6a870c3d06877336c19/go/infra/proto/cluster_types.proto#L117
The resource we define is map<string, int64> logical_resources = 6;
src/ray/protobuf/autoscaler.proto
Outdated
|
|
||
| message NodeGroupConfig { | ||
| map<string, double> resources = 1; | ||
| optional uint64 max_num_nodes = 2; |
Contributor
There was a problem hiding this comment.
Count as
// The minimum number of instances to launch.
int32 min_count = 3;
// The maximum number of instances to launch.
int32 max_count = 4;
Contributor
There was a problem hiding this comment.
-1 for max means infinite. Let's sync offline first and decide how to move forward.
src/ray/protobuf/autoscaler.proto
Outdated
|
|
||
| message ClusterConfig { | ||
| // Max resources for the entire cluster. | ||
| map<string, double> max_resources = 1; |
Contributor
There was a problem hiding this comment.
cluster level resources in Anyscale:
// If set, the global resource minimum in the cluster (based on a Ray defined or custom resource).
map<string, int64> min_resources = 106;
// If set, the global resource maximum in the cluster (based on a Ray defined or custom resource).
map<string, int64> max_resources = 107;
Contributor
brucez-anyscale
left a comment
There was a problem hiding this comment.
in general lgtm. Pls sync the ray proto with Anyscale proto types, namely int64 and int32
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 9, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
HYLcool
pushed a commit
to HYLcool/ray
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: lielin.hyl <lielin.hyl@alibaba-inc.com>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Example
ClusterConfigare:Libraries can use this information to do better autoscaling decisions.
Related issue number
Closes #49501
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.