[core] Make absl::StrCat import explicit to avoid build failures when using modern absl#48722
Merged
rynewang merged 4 commits intoray-project:masterfrom Dec 2, 2024
eugo-inc:fix-make-absl-strcat-import-explicit
Merged
[core] Make absl::StrCat import explicit to avoid build failures when using modern absl#48722rynewang merged 4 commits intoray-project:masterfrom eugo-inc:fix-make-absl-strcat-import-explicit
rynewang merged 4 commits intoray-project:masterfrom
eugo-inc:fix-make-absl-strcat-import-explicit
Conversation
Signed-off-by: gorloffslava <31761951+gorloffslava@users.noreply.github.com>
dentiny
approved these changes
Nov 13, 2024
Contributor
|
There is a small linting error that needs to be fixed before we can merge this PR :) |
Signed-off-by: Slava Gorlov <31761951+gorloffslava@users.noreply.github.com>
Contributor
Author
|
@pcmoritz fixed + synced with upstream. |
scv119
approved these changes
Nov 15, 2024
Contributor
Author
|
@scv119 gentle bump to see if we can get this merged. Of course, let me know if there’s anything I can help with. |
jecsand838
pushed a commit
to jecsand838/ray
that referenced
this pull request
Dec 4, 2024
… using modern absl (ray-project#48722) In [src/ray/object_manager/common.cc](https://github.com/ray-project/ray/blob/e393a716d8742a987a36df555defb2ca90bb94d4/src/ray/object_manager/common.cc) we extensively use `absl::StrCat` without explicitely importing the associated header `absl/strings/str_cat.h`. It worked fine previously, as `absl/strings/str_format.h` transitively included that via absl internal headers. However, somewhere in 2023-2024, absl has been cleaned up from unintentional transitive includes, breaking `ray` builds against modern absl. This PR fixes that. ## Effect on backward/forward compatability None. Builds against older absl versions will continue to work as before, as `absl::StrCat` was always declared in `str_cat.h` and including that was always the intended way to import this symbol. ## Related issues/PRs: + ray-project#48667 --------- Signed-off-by: gorloffslava <31761951+gorloffslava@users.noreply.github.com> Signed-off-by: Slava Gorlov <31761951+gorloffslava@users.noreply.github.com> Signed-off-by: Connor Sanders <connor@elastiflow.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
… using modern absl (ray-project#48722) In [src/ray/object_manager/common.cc](https://github.com/ray-project/ray/blob/e393a716d8742a987a36df555defb2ca90bb94d4/src/ray/object_manager/common.cc) we extensively use `absl::StrCat` without explicitely importing the associated header `absl/strings/str_cat.h`. It worked fine previously, as `absl/strings/str_format.h` transitively included that via absl internal headers. However, somewhere in 2023-2024, absl has been cleaned up from unintentional transitive includes, breaking `ray` builds against modern absl. This PR fixes that. ## Effect on backward/forward compatability None. Builds against older absl versions will continue to work as before, as `absl::StrCat` was always declared in `str_cat.h` and including that was always the intended way to import this symbol. ## Related issues/PRs: + ray-project#48667 --------- Signed-off-by: gorloffslava <31761951+gorloffslava@users.noreply.github.com> Signed-off-by: Slava Gorlov <31761951+gorloffslava@users.noreply.github.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In src/ray/object_manager/common.cc we extensively use
absl::StrCatwithout explicitely importing the associated headerabsl/strings/str_cat.h. It worked fine previously, asabsl/strings/str_format.htransitively included that via absl internal headers. However, somewhere in 2023-2024, absl has been cleaned up from unintentional transitive includes, breakingraybuilds against modern absl. This PR fixes that.Effect on backward/forward compatability
None. Builds against older absl versions will continue to work as before, as
absl::StrCatwas always declared instr_cat.hand including that was always the intended way to import this symbol.Related issues/PRs: