Skip to content

Revert "Revert "[Data] Add BundleQueue abstraction (#48503)" (#48612)"#48686

Merged
bveeramani merged 3 commits intomasterfrom
readd-bundle-queue
Nov 13, 2024
Merged

Revert "Revert "[Data] Add BundleQueue abstraction (#48503)" (#48612)"#48686
bveeramani merged 3 commits intomasterfrom
readd-bundle-queue

Conversation

@bveeramani
Copy link
Copy Markdown
Member

This reverts commit 4a9c424.

Here's the diff that fixes the regression. Essentially, the original PR didn't account for the "split queues".
image

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

This reverts commit 4a9c424.

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani added the go add ONLY when ready to merge, run all tests label Nov 11, 2024
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani enabled auto-merge (squash) November 13, 2024 17:14
@bveeramani bveeramani merged commit 4b4cdcd into master Nov 13, 2024
@bveeramani bveeramani deleted the readd-bundle-queue branch November 13, 2024 18:09
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
…)" (ray-project#48612)" (ray-project#48686)

This reverts commit 4a9c424.

---------

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants