[core] [8/N] Enable validation for uv installtion#48670
Merged
jjyao merged 5 commits intoray-project:masterfrom Nov 12, 2024
Merged
[core] [8/N] Enable validation for uv installtion#48670jjyao merged 5 commits intoray-project:masterfrom
jjyao merged 5 commits intoray-project:masterfrom
Conversation
Signed-off-by: dentiny <dentinyhao@gmail.com>
Contributor
|
Rebase |
Signed-off-by: dentiny <dentinyhao@gmail.com>
Contributor
Author
Rebased. |
jjyao
reviewed
Nov 12, 2024
|
|
||
|
|
||
| # Package installation succeeds, with compatibility enabled. | ||
| def test_package_install_with_uv_and_validation(shutdown_only): |
Contributor
There was a problem hiding this comment.
Can you add a test where uv check fails?
Contributor
Author
There was a problem hiding this comment.
I think it's hard.
- Package installation already checks conflicts, checkout
ray/python/ray/tests/test_runtime_env_conda_and_pip_5.py
Lines 63 to 89 in 0251a3e
- The only way I could think of faking and testing
pip_checkfailure, is you download a series of compatible packages, enter into the virtual environment and modify the packages manually - I don't think it's viable based on our current test setup, since everything's constructed and destructed when
ray.remotefinishes, which you don't have a way to hack in
Signed-off-by: dentiny <dentinyhao@gmail.com>
jjyao
approved these changes
Nov 12, 2024
Signed-off-by: dentiny <dentinyhao@gmail.com>
Contributor
Author
|
Hi @jjyao , I think the failed unit test (the |
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
Signed-off-by: dentiny <dentinyhao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last missing feature for uv runtime env setup, which checks the package compatibility.