Skip to content

[core] [6/N] Allow users to specify uv version to install#48634

Merged
jjyao merged 15 commits intoray-project:masterfrom
dentiny:hjiang/uv-install-version
Nov 12, 2024
Merged

[core] [6/N] Allow users to specify uv version to install#48634
jjyao merged 15 commits intoray-project:masterfrom
dentiny:hjiang/uv-install-version

Conversation

@dentiny
Copy link
Copy Markdown
Contributor

@dentiny dentiny commented Nov 7, 2024

Followup PR on #48611, this PR allows user to user a specific version of uv.

I think I did a bad thing: I push all my commits into dentiny/ray instead of ray-project/ray, which makes it hard to compare base branch across two repositories :(

The only commit to review is: 6d2092e

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny requested review from jjyao and rynewang November 7, 2024 21:20
@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Nov 7, 2024
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny force-pushed the hjiang/uv-install-version branch from ab47b4e to 3e3c516 Compare November 8, 2024 08:24
@jjyao
Copy link
Copy Markdown
Contributor

jjyao commented Nov 8, 2024

Rebase.

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny force-pushed the hjiang/uv-install-version branch from 8a231fc to 1394249 Compare November 8, 2024 20:29
@dentiny
Copy link
Copy Markdown
Contributor Author

dentiny commented Nov 8, 2024

Rebase.

Rebased!

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny requested a review from jjyao November 9, 2024 01:38
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny requested a review from jjyao November 12, 2024 07:31
@jjyao jjyao merged commit d6d5863 into ray-project:master Nov 12, 2024
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants