[Core] Cancel lease requests before returning a PG bundle#46116
Merged
jjyao merged 6 commits intoray-project:masterfrom Jun 20, 2024
Merged
[Core] Cancel lease requests before returning a PG bundle#46116jjyao merged 6 commits intoray-project:masterfrom
jjyao merged 6 commits intoray-project:masterfrom
Conversation
jjyao
commented
Jun 19, 2024
Comment on lines
+1908
to
+1909
| return (bundle_id.first == bundle_spec.PlacementGroupId()) && | ||
| (work->GetState() == internal::WorkStatus::WAITING_FOR_WORKER); |
Contributor
Author
There was a problem hiding this comment.
Fix for the revert: CancelResourceReserve rpc might be called when prepare failed and in this case, we shouldn't cancel the lease request since the PG will be retried and created eventually. So this fix only limits the cancellation to the lease requests that are waiting for workers since this is the case where we need to free bundle resources.
rynewang
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Redo ##45919
Related issue number
Closes #45642
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.