[Core][Node Labels 1/n] Add --labels param in ray start command to setting node labels#35433
Merged
jjyao merged 1 commit intoray-project:masterfrom Jun 1, 2023
Merged
Conversation
jjyao
reviewed
May 24, 2023
python/ray/scripts/scripts.py
Outdated
Contributor
There was a problem hiding this comment.
maybe hidden=True, for now and we can make it public after we finish everything
d135b72 to
e88f744
Compare
jjyao
approved these changes
May 24, 2023
Contributor
|
@pcmoritz could you review the core API change? |
|
The linkcheck error has been fixed elsewhere in this commit: d0153a3 |
9ca7b4b to
1435d50
Compare
jiwq
reviewed
May 30, 2023
…ting node labels Signed-off-by: LarryLian <554538252@qq.com>
pcmoritz
approved these changes
Jun 1, 2023
28 tasks
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…ting node labels (ray-project#35433) Enhancing node affinity scheduling feature through node labels ray-project#34894 Signed-off-by: LarryLian <554538252@qq.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ting node labels (ray-project#35433) Enhancing node affinity scheduling feature through node labels ray-project#34894 Signed-off-by: LarryLian <554538252@qq.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
python/ray/tests/test_node_labels.py
Other exceptional scenarios and boundary scenarios testing will be added later by new PR.
Related issue number
Enhancing node affinity scheduling feature through node labels #34894
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.