Skip to content

[docs] sphinx design 7/N (fin!)#35037

Merged
pcmoritz merged 15 commits intomasterfrom
mp_sphinx_design_7
May 7, 2023
Merged

[docs] sphinx design 7/N (fin!)#35037
pcmoritz merged 15 commits intomasterfrom
mp_sphinx_design_7

Conversation

@maxpumperla
Copy link
Copy Markdown
Contributor

last PR for this migration, next up would be a sphinx + theme upgrade

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla maxpumperla requested a review from gjoliver as a code owner May 4, 2023 14:27
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@angelinalg
Copy link
Copy Markdown
Contributor

I did a review of the text. Could someone else please review the code?

Copy link
Copy Markdown
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maxpumperla and others added 2 commits May 5, 2023 08:08
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@pcmoritz
Copy link
Copy Markdown
Contributor

pcmoritz commented May 7, 2023

The Ray Cluster getting started layout is a little out of order at the moment:

Screen Shot 2023-05-07 at 11 32 53 AM

Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
@pcmoritz pcmoritz merged commit 386e395 into master May 7, 2023
@pcmoritz pcmoritz deleted the mp_sphinx_design_7 branch May 7, 2023 21:39
@maxpumperla
Copy link
Copy Markdown
Contributor Author

@pcmoritz thanks for spotting this -- and the fix

@pcmoritz
Copy link
Copy Markdown
Contributor

pcmoritz commented May 8, 2023

Ofc and thanks for upgrading the docs, that's really great :)

architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
last PR for this migration, next up would be a sphinx + theme upgrade

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants