Skip to content

[Core] Remove dead code related to multiple workers in one process#33074

Merged
jjyao merged 2 commits intoray-project:masterfrom
jjyao:jjyao/red
Mar 7, 2023
Merged

[Core] Remove dead code related to multiple workers in one process#33074
jjyao merged 2 commits intoray-project:masterfrom
jjyao:jjyao/red

Conversation

@jjyao
Copy link
Copy Markdown
Contributor

@jjyao jjyao commented Mar 6, 2023

Why are these changes needed?

Multiple workers in one process is removed in #24147 but there is still some dead code

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jovany-wang
Copy link
Copy Markdown
Contributor

Nice catch!

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from jovany-wang March 7, 2023 05:56
Copy link
Copy Markdown
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjyao jjyao merged commit c0aa534 into ray-project:master Mar 7, 2023
@jjyao jjyao deleted the jjyao/red branch March 7, 2023 16:30
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
…ay-project#33074)

Multiple workers in one process is removed in ray-project#24147 but there is still some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…ay-project#33074)

Multiple workers in one process is removed in ray-project#24147 but there is still some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
…ay-project#33074)

Multiple workers in one process is removed in ray-project#24147 but there is still some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…ay-project#33074)

Multiple workers in one process is removed in ray-project#24147 but there is still some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…ay-project#33074)

Multiple workers in one process is removed in ray-project#24147 but there is still some dead code

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants