[Datasets] Streaming executor fixes #5#32951
Merged
ericl merged 8 commits intoray-project:masterfrom Mar 5, 2023
Merged
Conversation
clarkzinzow
reviewed
Mar 1, 2023
Contributor
There was a problem hiding this comment.
Hmm it seems like this cached_metadata should always be homogeneous, i.e. it should always contain a BlockMetadata for each element. Do you know how this heterogeneity is happening?
Contributor
Author
There was a problem hiding this comment.
We set only the first block when figuring out the schema, so e.g. with this:
import ray
inputs = ["example://iris.csv"] * 100
ds = ray.data.read_csv(inputs, parallelism=10)
print("before:", ds._plan._in_blocks._cached_metadata)
ds.schema()
print("after:", ds._plan._in_blocks._cached_metadata)
ds._plan._in_blocks.split(2)
It's producing:
before: [None, None, None, None, None, None, None, None, None, None]
after: [[BlockMetadata(num_rows=1500, size_bytes=66500, schema=sepal.length: double
sepal.width: double
petal.length: double
petal.width: double
variety: string, input_files=array(['/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv',
'/home/ubuntu/ray/python/ray/data/examples/data/iris.csv'],
dtype='<U55'), exec_stats={'wall_time_s': 0.36291642487049103, 'cpu_time_s': 0.3410033880000001, 'node_id': 'f3e389087180baf4bcde82efe3873d1139be957718e69465786af17d'})], None, None, None, None, None, None, None, None, None]
Contributor
There was a problem hiding this comment.
Could we pull this out into an array split util and use it for the above splits too?
Otherwise it's not clear this is doing the same thing as array split.
jianoaix
commented
Mar 2, 2023
Contributor
Author
There was a problem hiding this comment.
The purpose of this test is testing ExecutionPlan.execute() so we run it directly. Running ds.take() may invoke the new execution backend when the flag is on.
ericl
approved these changes
Mar 2, 2023
11c5af8 to
90954c5
Compare
90954c5 to
6b7130b
Compare
Contributor
Author
|
Tests passing (the failures are relevant to this pr). |
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ExecutionPlan.execute()directly (instead ofds.take()) when the purpose is to testExecutionPlan.execute(): if usingds.take()it may run the new execution backend which doesn't invoke the `ExecutionPlan.execute()'Related issue number
#32132
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.