Skip to content

Single sourcing the package version#3220

Merged
pcmoritz merged 1 commit intoray-project:masterfrom
xutianming:master
Nov 4, 2018
Merged

Single sourcing the package version#3220
pcmoritz merged 1 commit intoray-project:masterfrom
xutianming:master

Conversation

@xutianming
Copy link
Copy Markdown
Contributor

What do these changes do?

Single sourcing the package version in setup.py and retrieve the version using package_resources in init.py.
Currently, package version strings are hard-coded in both setup.py and init.py. It leads to potential inconsistency.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9034/
Test PASSed.

@robertnishihara
Copy link
Copy Markdown
Collaborator

This seems to cause some issues, e.g., for our linting build in Travis.

How about we do something like what Celery does? E.g., they have the version string in celery/__init__.py

https://github.com/celery/celery/blob/9559045b8fd5cb4d6a99b02c39aff77ab537f234/celery/__init__.py#L17-L22

Then in setup.py they parse the celery/__init__.py and pull out the version.

https://github.com/celery/celery/blob/9559045b8fd5cb4d6a99b02c39aff77ab537f234/setup.py#L116-L129

Ours can be simpler though.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9047/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9048/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9049/
Test PASSed.

Copy link
Copy Markdown
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM!

@pcmoritz pcmoritz merged commit fb6ac28 into ray-project:master Nov 4, 2018
williamma12 pushed a commit to williamma12/ray that referenced this pull request Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants