[Tune] Make remote_checkpoint_dir work with query strings#30125
Merged
amogkam merged 4 commits intoray-project:masterfrom Nov 9, 2022
Merged
[Tune] Make remote_checkpoint_dir work with query strings#30125amogkam merged 4 commits intoray-project:masterfrom
remote_checkpoint_dir work with query strings#30125amogkam merged 4 commits intoray-project:masterfrom
Conversation
remote_checkpoint_dir work with query strings
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ect#30125) * Initial comit * Undo unnecessary changes * Remove remote_storage changes * Update test_experiment.py Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Balaji balaji@anyscale.com
Why are these changes needed?
Users want to upload checkpoints to non-AWS S3 filesystems, but they can't.
To upload to a non-AWS S3 filesystem, you need to specify
endpoint_overrideas a query parameter. However,Experiment.remote_checkpoint_dirbehaves poorly ifSyncConfig.upload_dircontains a query string:This PR fixes the issue by updating
Experiment.remote_checkpoint_dirto parse query strings.Related issue number
Closes #29845
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.