Skip to content

[Tune] Make remote_checkpoint_dir work with query strings#30125

Merged
amogkam merged 4 commits intoray-project:masterfrom
bveeramani:upload-dir
Nov 9, 2022
Merged

[Tune] Make remote_checkpoint_dir work with query strings#30125
amogkam merged 4 commits intoray-project:masterfrom
bveeramani:upload-dir

Conversation

@bveeramani
Copy link
Copy Markdown
Member

@bveeramani bveeramani commented Nov 9, 2022

Signed-off-by: Balaji balaji@anyscale.com

Why are these changes needed?

Users want to upload checkpoints to non-AWS S3 filesystems, but they can't.

To upload to a non-AWS S3 filesystem, you need to specify endpoint_override as a query parameter. However, Experiment.remote_checkpoint_dir behaves poorly if SyncConfig.upload_dir contains a query string:

>>> experiment = Experiment(
...         name="spam",
...         run=lambda config: config,
...         sync_config=SyncConfig(syncer="auto", upload_dir="s3://bucket?scheme=http"),
... )
>>> experiment.remote_checkpoint_dir
s3://bucket?scheme=http/spam

This PR fixes the issue by updating Experiment.remote_checkpoint_dir to parse query strings.

Related issue number

Closes #29845

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani changed the title [Tune] Fix uploads to filesystems that emulate S3 APIs [Tune] Make remote_checkpoint_dir work with query strings Nov 9, 2022
Copy link
Copy Markdown
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amogkam amogkam merged commit f28d731 into ray-project:master Nov 9, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ect#30125)

* Initial comit

* Undo unnecessary changes

* Remove remote_storage changes

* Update test_experiment.py

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AIR] Syncing when upload_url="s3://<my_s3_bucket>?<endpoint_and_other_argument_overrides>"

3 participants