[ci/docker/air] Update ML/DL dependencies to latest releases / Remove Py3.6 Docker images#28808
Merged
krfricke merged 39 commits intoray-project:masterfrom Oct 27, 2022
Merged
Conversation
added 4 commits
September 27, 2022 11:11
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
added 19 commits
September 27, 2022 11:57
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
…ir-update-dependencies
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
…endencies # Conflicts: # python/requirements/ml/requirements_rllib.txt
Signed-off-by: Kai Fricke <kai@anyscale.com>
Contributor
Author
|
Tests are passing except for some in RLlib - I will work with the rllib team to resolve this. But the rest is ready for review cc @pcmoritz @richardliaw for general testing infrastructure The base CI GPU image has been updated to support CUDA 11.6 already. |
Contributor
|
I guess this PR could incorporate, supercede and close #26072? |
# Conflicts: # docker/ray-ml/Dockerfile # python/requirements/ml/requirements_tune.txt
Contributor
Author
@ddelange how about we do this in two steps - merge this first and land your changes once pyg-team/pyg-lib#66 is addressed? |
Contributor
|
totally fine by me :) |
added 3 commits
October 20, 2022 14:06
Signed-off-by: Kai Fricke <kai@anyscale.com>
amogkam
approved these changes
Oct 21, 2022
Closed
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
added 2 commits
October 25, 2022 18:09
Signed-off-by: Kai Fricke <kai@anyscale.com>
richardliaw
approved these changes
Oct 26, 2022
added 2 commits
October 26, 2022 14:33
Signed-off-by: Kai Fricke <kai@anyscale.com>
# Conflicts: # rllib/tests/run_regression_tests.py
|
|
||
| # Test against all frameworks. | ||
| for _ in framework_iterator(config, with_eager_tracing=True): | ||
| for _ in framework_iterator(config, with_eager_tracing=False): |
Contributor
There was a problem hiding this comment.
@gjoliver @kouroshHakha Not sure why this test did not fail initially, but A3C seems error with eager tracing as well, right @krfricke ?
7 tasks
6 tasks
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
… Py3.6 Docker images (ray-project#28808) This PR upgrades some of our dependencies to the latest releases. At the moment, we are testing with a lower bound of dependencies. This is good as we ensure compatibility with these versions, but at the same time we don't test compatibility with more recent releases. We prioritize backwards compatibility over compatibility with more recent versions. This PR: - Introduces a set of _legacy dependencies_ (the current versions in the CI). - This is a lower bound of dependencies that we guarantee compatibility with - The regular dependencies are upgraded to more recent releases - We remove Docker builds for Python 3.6. as this is incompatible with more recent versions of tensorflow/torch - Wheel building for 3.6 is not affected. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Co-authored-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR upgrades some of our dependencies to the latest releases.
At the moment, we are testing with a lower bound of dependencies. This is good as we ensure compatibility with these versions, but at the same time we don't test compatibility with more recent releases. We prioritize backwards compatibility over compatibility with more recent versions.
This PR:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.