[Core][Python 3.10] fix get_module in the interactive mode. #25032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
May 20, 2022
mwtian
approved these changes
May 20, 2022
Member
mwtian
left a comment
There was a problem hiding this comment.
Maybe add comment for the issue as well?
fishbone
approved these changes
May 20, 2022
scv119
added a commit
to scv119/ray
that referenced
this pull request
May 20, 2022
…ct#25032 in python3.10, it fixed a bug that a interactively defined class was tagged with a wrong type during inspection; which now throws OSError. detailed pr python/cpython#27171 we need to handle this case properly in otherwise ray actor definition will throw in interactive mode. please refer to ray-project#25026 for repo.
scv119
added a commit
that referenced
this pull request
May 21, 2022
…25042) in python3.10, it fixed a bug that a interactively defined class was tagged with a wrong type during inspection; which now throws OSError. detailed pr python/cpython#27171 we need to handle this case properly in otherwise ray actor definition will throw in interactive mode. please refer to #25026 for repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
in python3.10, it fixed a bug that a interactively defined class was tagged with a wrong type during inspection; which now throws OSError. detailed pr python/cpython#27171
we need to handle this case properly in otherwise ray actor definition will throw in interactive mode. please refer to #25026 for repo.
Related issue number
closes #25026
Checks
scripts/format.shto lint the changes in this PR.