Skip to content

[tune] increase timeout for ray_trial_executor_test.#22658

Merged
richardliaw merged 1 commit intoray-project:masterfrom
xwjiang2010:deflake_ray_trial_executor_test
Feb 25, 2022
Merged

[tune] increase timeout for ray_trial_executor_test.#22658
richardliaw merged 1 commit intoray-project:masterfrom
xwjiang2010:deflake_ray_trial_executor_test

Conversation

@xwjiang2010
Copy link
Copy Markdown
Contributor

@xwjiang2010 xwjiang2010 commented Feb 25, 2022

Why are these changes needed?

The test has been pretty borderline (290s v.s. 300s threshold for a medium sized test suite). Increase to large to reduce noise. We can later see if we want to improve the test time.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@richardliaw richardliaw merged commit 62b2c26 into ray-project:master Feb 25, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
@xwjiang2010 xwjiang2010 deleted the deflake_ray_trial_executor_test branch July 26, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants