[Test] Increase timeout for microbenchmark#22655
Merged
rkooo567 merged 1 commit intoray-project:masterfrom Feb 26, 2022
Merged
Conversation
jjyao
approved these changes
Feb 25, 2022
Contributor
|
Could you create an issue to track the actual regression? |
Contributor
Author
|
Let me do that in a few days (I will keep checking the tendency) |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It seems like microbenchmark takes 14 minutes to finish, whereas the timeout is 15m. We should increase it for the safety. (it's also flaky because of that).
If it takes 15 minutes due to regression, we should fix it separately. Regardless we should increase the timeout.
Related issue number
Closes #22635
Checks
scripts/format.shto lint the changes in this PR.