[3/X][Pipeline] Handle deployment handle replacement in DeploymentNode init args, support nested#22646
Merged
edoakes merged 15 commits intoray-project:masterfrom Feb 26, 2022
Conversation
…e for shared deployment handle
…ipeline_nested_deployment_handle_rep git pull upstream master
edoakes
requested changes
Feb 25, 2022
…ipeline_nested_deployment_handle_rep
edoakes
approved these changes
Feb 26, 2022
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
One nit, please address in follow up
| ) | ||
| ) | ||
|
|
||
| def _apply_functional( |
Collaborator
There was a problem hiding this comment.
shouldn't be prefixed with _ if public method
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
…e init args, support nested (ray-project#22646) - Moved all `Deployment` instance creation to `DeploymentNode` level with only relevant info passed into it from `generate.py`. This abstraction makes more sense and less leaky. - In `DeploymentNode`, we leverage ray core DAG's `_PyObjScanner` to find and replace only Deployment nodes init args & kwargs to deployment handle, which is only specific to `Deployment` instance, but not `DeploymentNode` itself. However this is the simplest and most robust way to handle nested args at `DAGNode` level. - This implementation lives in ray core DAGNode level so we don't need to expose `_PyObjScanner` directly. - Added serve pipeline tests to BUILD CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Deploymentinstance creation toDeploymentNodelevel with only relevant info passed into it fromgenerate.py. This abstraction makes more sense and less leaky.DeploymentNode, we leverage ray core DAG's_PyObjScannerto find and replace only Deployment nodes init args & kwargs to deployment handle, which is only specific toDeploymentinstance, but notDeploymentNodeitself. However this is the simplest and most robust way to handle nested args atDAGNodelevel._PyObjScannerdirectly.Next steps
Checks
scripts/format.shto lint the changes in this PR.