Skip to content

Revert "[runtime env] runtime env inheritance refactor (#22244)"#22626

Merged
edoakes merged 4 commits intoray-project:masterfrom
xwjiang2010:revert_5783cdb
Feb 25, 2022
Merged

Revert "[runtime env] runtime env inheritance refactor (#22244)"#22626
edoakes merged 4 commits intoray-project:masterfrom
xwjiang2010:revert_5783cdb

Conversation

@xwjiang2010
Copy link
Copy Markdown
Contributor

@xwjiang2010 xwjiang2010 commented Feb 24, 2022 •
edited
Loading

This reverts commit 5783cdb.

Why are these changes needed?

Breaks train_torch_linear_test.py.

Related issue number

#22595

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010 xwjiang2010 requested review from SongGuyang and rkooo567 and removed request for SongGuyang February 24, 2022 15:34
@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 24, 2022
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Feb 24, 2022

There was a failure in the redis HA test, looked like just infra failure, retrying

@xwjiang2010
Copy link
Copy Markdown
Contributor Author

xwjiang2010 commented Feb 24, 2022

Tune and RLlib test failures are unrelated. Can someone take a final pass and merge it? Thanks!

@xwjiang2010 xwjiang2010 added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Feb 24, 2022
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Feb 24, 2022

Mac builds are still pending

@edoakes edoakes added @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. and removed tests-ok The tagger certifies test failures are unrelated and assumes personal liability. labels Feb 24, 2022
@edoakes edoakes merged commit d4a1bc7 into ray-project:master Feb 25, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
@xwjiang2010 @simonsays1980
Revert "[runtime env] runtime env inheritance refactor (ray-project#2…
ebce453 
…2244)" (ray-project#22626)

Breaks train_torch_linear_test.py.
@xwjiang2010 xwjiang2010 deleted the revert_5783cdb branch July 26, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edoakes edoakes edoakes approved these changes

@SongGuyang SongGuyang SongGuyang approved these changes

@rkooo567 rkooo567 Awaiting requested review from rkooo567

Assignees

@architkulkarni architkulkarni

@edoakes edoakes

@rkooo567 rkooo567

@SongGuyang SongGuyang

Labels

@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xwjiang2010 @edoakes @SongGuyang @architkulkarni @rkooo567