[RLlib] SlateQ: Add a hard-task learning test to weekly regression suite.#22544
Merged
sven1977 merged 41 commits intoray-project:masterfrom Feb 25, 2022
Merged
[RLlib] SlateQ: Add a hard-task learning test to weekly regression suite.#22544sven1977 merged 41 commits intoray-project:masterfrom
sven1977 merged 41 commits intoray-project:masterfrom
Conversation
# Conflicts: # rllib/agents/slateq/slateq.py
…eq_torch_cleanups # Conflicts: # .buildkite/pipeline.ml.yml # rllib/BUILD # rllib/agents/slateq/slateq.py # rllib/agents/slateq/slateq_tf_model.py # rllib/agents/slateq/slateq_tf_policy.py # rllib/agents/slateq/slateq_torch_model.py # rllib/agents/slateq/slateq_torch_policy.py # rllib/agents/slateq/tests/test_slateq.py # rllib/tuned_examples/slateq/interest-evolution-10-candidates-recsim-env-slateq.yaml # rllib/tuned_examples/slateq/interest-evolution-50-candidates-recsim-env-slateq.yaml # rllib/tuned_examples/slateq/interest-evolution-recsim-env-slateq.yaml
gjoliver
approved these changes
Feb 23, 2022
Member
gjoliver
left a comment
There was a problem hiding this comment.
this PR probably included diffs from the other slateq torch PR.
might want to rebase then merge after the other PR is in.
| - bazel test --config=ci $(./scripts/bazel_export_options) | ||
| --build_tests_only | ||
| --test_tag_filters=learning_tests_discrete,-fake_gpus,-torch_only,-tf2_only | ||
| --test_tag_filters=learning_tests_discrete,-fake_gpus,-torch_only,-tf2_only,-no_tf_static_graph |
Member
There was a problem hiding this comment.
I am just curious about these tags. where can I use them?
Contributor
Author
There was a problem hiding this comment.
They are defined in the rllib/BUILD file. You can make up any tags and filter by these on the BAZEL command line.
Contributor
Author
|
You are right, some diffs need to be merged first. ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlateQ: Add a hard-task learning test to weekly regression suite.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.